Reaper Grimm
Register | User Profile | Member List | F.A.Q | Privacy Policy | New Blog | Search Forums | Forums Home
Doomworld Forums : Powered by vBulletin version 2.2.5 Doomworld Forums > Classic Doom > Doom General > Is there a fixed version of TNT's MAP02 music?
 
Author
All times are GMT. The time now is 04:56. Post New Thread    Post A Reply
Marcaek
Forum Regular


Posts: 713
Registered: 12-10
I know modern ports account for the error in this track automatically, but I'd still like to have a fixed version of the actual file if it exists.
Old Post 01-07-12 05:53 #
Marcaek is online now Profile || Blog || PM || Email || Search || Add Buddy IP || Edit/Delete || Quote
NoobBait
Member


Posts: 413
Registered: 12-10
Pardon my ignorance, but what is the error?
Old Post 01-07-12 15:50 #
NoobBait is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
natt
Junior Member


Posts: 248
Registered: 05-11
Gez said:
There's a bug with TNT's map 2 music that has been fixed recently. (A volume instruction overflowed. MIDI expects a certain value to be on 7-bit, up to 127, but here in the MUS it is 128 so if simply transfered the 8th bit is stripped and it becomes 0... Now it makes sure it changes to 127 instead.)


I don't think prboom-plus fixes this though...
Old Post 01-07-12 16:37 #
natt is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Grazza
Super Moderator


Posts: 11450
Registered: 07-02
prboom-plus changelog said:

2.4.8.2 @ 2007-10-16
...
[+] New mus -> mid conversion code thanks to Ben Ryves. This removes bugs and plays back a lot of music closer to Vanilla Doom - eg. tnt.wad map02.
Old Post 01-07-12 17:12 #
Grazza is online now Profile || Blog || PM || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
natt
Junior Member


Posts: 248
Registered: 05-11
Edit: Retract previous statement. Prboom-plus does fix this (and has for quite a while, as stated). My confusion.

Back to the original question, I could hex up a "fixed" version if I had the original MUS. Not sure what the point would be though, since all source-ports can fix this in their mus->mid code.

Last edited by natt on 01-07-12 at 18:32
Old Post 01-07-12 18:16 #
natt is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7042
Registered: 07-07
Yeah, it works okay in at least GL/PrBoom+, Chocolate Doom, the latest version of Eternity, and SVN builds of ZDoom and GZDoom. In addition to these ports, it also works in SLADE 3. Other ports might also feature the fix of course.

Anybody wanting to use the code can. It's quite trivial and Ben Ryves, when I contacted him about porting the fix to ZDoom, told me it was under the WTFPL

natt said:
Back to the original question, I could hex up a "fixed" version if I had the original MUS.


Look in Jimmy's Jukebox.
Old Post 01-07-12 18:40 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
natt
Junior Member


Posts: 248
Registered: 05-11
Gez said:

Look in Jimmy's Jukebox.


Got it. This the right file?

code:

  File: D_TNT_02.mus
CRC-32: 3ac69180
   MD4: d9fe285c3c2c61aee3fff8c6dd0c3f67
   MD5: 90465bc20f4fc2974c0df6dc21eb2fc3
 SHA-1: f4721b6c93b00a3fbf8dd24c2db6f2cabe9e2626

Old Post 01-07-12 18:56 #
natt is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7042
Registered: 07-07
D_STALKS in TNT.wad also has a CRC-32 of 3ac69180, so yeah, it's the exact same.
Old Post 01-07-12 19:39 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
natt
Junior Member


Posts: 248
Registered: 05-11
Fixed mus:

http://www.mediafire.com/?pbise0xidp679w8

If anyone's interested, I wrote a short program (in spaghetti C) to do this; you can have the source if you want. It's pretty useless though.
Old Post 01-07-12 20:11 #
natt is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Marcaek
Forum Regular


Posts: 713
Registered: 12-10
I wasn't aware that the music fix was applied to so many ports.

Thanks for this regardless.
Old Post 01-07-12 22:23 #
Marcaek is online now Profile || Blog || PM || Email || Search || Add Buddy IP || Edit/Delete || Quote
Technician
Still no custom title


Posts: 5771
Registered: 08-04
NoobBait said:
Pardon my ignorance, but what is the error?

Old Post 01-07-12 23:03 #
Technician is online now Profile || Blog || PM || Email || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7042
Registered: 07-07
Technician said:

I'd feel silly quoting natt quoting myself, so just scroll up. A volume meant to be the maximum is instead read as being the minimum, so an instrument is not heard.

There's been a few thread already on the subject.
Old Post 01-07-12 23:34 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
All times are GMT. The time now is 04:56. Post New Thread    Post A Reply
 
Doomworld Forums : Powered by vBulletin version 2.2.5 Doomworld Forums > Classic Doom > Doom General > Is there a fixed version of TNT's MAP02 music?

Show Printable Version | Email this Page | Subscribe to this Thread

 

Forum Rules:
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts 		HTML code is OFF
vB code is ON
Smilies are OFF
[IMG] code is ON
 

< Contact Us - Doomworld >

Powered by: vBulletin Version 2.2.5
Copyright ©2000, 2001, Jelsoft Enterprises Limited.

Forums Directory