Doom Marine
Register | User Profile | Member List | F.A.Q | Privacy Policy | New Blog | Search Forums | Forums Home
Doomworld Forums : Powered by vBulletin version 2.2.5 Doomworld Forums > Special Interest > Eternity > psxwadgen question
 
Author
All times are GMT. The time now is 15:55. Post New Thread    Post A Reply
Gez
Why don't I have a custom title by now?!


Posts: 10709
Registered: 07-07


I was reading the changelog (found many amusing or interesting stuff in it) and saw this:

Upstreamed some important copy construction glitch fixes for Collection and PODCollection from my psxwadgen project, where I caused undefined behavior by trying to copy-construct them in the patch conversion code adopted from SLADE.

Just to be clear -- the undefined behavior came from SLADE's conversion code or purely on your code's side? I want to know if I have something to fix.

Old Post 12-24-13 11:02 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Quasar
Moderator


Posts: 5763
Registered: 08-00



Gez said:
I was reading the changelog (found many amusing or interesting stuff in it) and saw this:

Just to be clear -- the undefined behavior came from SLADE's conversion code or purely on your code's side? I want to know if I have something to fix.


I replaced the uses there of vector<> with Eternity's PODCollection<> and Collection<> classes, which were not quite as robust as they needed to be. There's no issue in SLADE :)

Old Post 12-25-13 01:05 #
Quasar is offline Profile || Blog || PM || Email || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
All times are GMT. The time now is 15:55. Post New Thread    Post A Reply
 
Doomworld Forums : Powered by vBulletin version 2.2.5 Doomworld Forums > Special Interest > Eternity > psxwadgen question

Show Printable Version | Email this Page | Subscribe to this Thread

 

Forum Rules:
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is OFF
vB code is ON
Smilies are OFF
[IMG] code is ON
 

< Contact Us - Doomworld >

Powered by: vBulletin Version 2.2.5
Copyright ©2000, 2001, Jelsoft Enterprises Limited.

Message Board Statistics