Doom Marine
Register | User Profile | Member List | F.A.Q | Privacy Policy | New Blog | Search Forums | Forums Home
Doomworld Forums : Powered by vBulletin version 2.2.5 Doomworld Forums > Classic Doom > Source Ports > MUS Format Recommendation
 
Author
All times are GMT. The time now is 02:21. Post New Thread    Post A Reply
Quasar
Moderator


Posts: 4615
Registered: 08-00


TheGreenHerring discovered a wad in the /idgames archive called DIESCUM.WAD which has a very strange oddity about it - its music lump is embedded inside an inner wad file, and the lump entry points to the beginning of the wad rather than to the beginning of the MUS lump. However, vanilla DOOM plays this music normally.

This suggests that the DMX library is capable of scanning forward for a MUS header in the data that is passed to it. I have implemented such a forward scan in EE r1084 and it fixes playing the music on this map. I'd recommend this minor tweak to any port interested in high fidelity even for crappy malformed wad files ;)

Old Post 04-05-10 06:30 #
Quasar is offline Profile || Blog || PM || Email || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
DaniJ
Senior Member


Posts: 1740
Registered: 08-03


Thanks for the heads-up! Will address in Doomsday for a future release.

Old Post 04-05-10 12:26 #
DaniJ is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7046
Registered: 07-07


Dunno what tool was used to generate this file, but it did a very poor job. This is a severely malformed wad.

Old Post 04-05-10 14:33 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
GreyGhost
a ghost... only grey


Posts: 5703
Registered: 01-08


The tool's only as good as the user. XWE and SLumpEd will let careless users make the same mistake, though SLumpEd does at least identify the lump as a wad file.

Old Post 04-05-10 16:22 #
GreyGhost is offline Profile || Blog || PM || Email || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7046
Registered: 07-07


Yeah but what of the hundred empty lumps that come after it?

Old Post 04-05-10 17:49 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Quasar
Moderator


Posts: 4615
Registered: 08-00



Gez said:
Yeah but what of the hundred empty lumps that come after it?

At least the directory is valid though. ;)

We're having a lot of trouble lately with wads popping up in the archive which have invalid blockmaps. Evidently the number of them out there is staggering. Virtually all of them have some minor corruption (whether a result of a bad tool or of some type of "bit rot" is unknown) that leads to indexing the linedefs array out of bounds.

Old Post 04-05-10 19:34 #
Quasar is offline Profile || Blog || PM || Email || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7046
Registered: 07-07



Quasar said:
At least the directory is valid though. ;)

I'm not even sure about that since the SLADE3 beta doesn't read it correctly. (Why is a mystery to me, the algorithm used is exactly the same as in Slumped, which does read it correctly.)

But look at this:
http://img263.imageshack.us/img263/1046/diescum.png
Seems to me there are two different directories here... The one that's used is the second. In the first we see the infamous PLATFORM lump. Then there's a long list of null bytes which are interpreted as the offsets, lengths and names of a bunch of lumps, since 111 of them are supposed to exist in total.

Old Post 04-05-10 19:47 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
kristus
Megablast!


Posts: 9683
Registered: 07-00


The platform lump comes from Doomed, where it allows naming of the tags.

The funnyness of this wad is possibly a result of using it's WAD editor featured in v 4.2

Old Post 04-05-10 20:15 #
kristus is offline Profile || Blog || PM || Email || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
Quasar
Moderator


Posts: 4615
Registered: 08-00



Gez said:

I'm not even sure about that since the SLADE3 beta doesn't read it correctly. (Why is a mystery to me, the algorithm used is exactly the same as in Slumped, which does read it correctly.)

But look at this:
pic
Seems to me there are two different directories here... The one that's used is the second. In the first we see the infamous PLATFORM lump. Then there's a long list of null bytes which are interpreted as the offsets, lengths and names of a bunch of lumps, since 111 of them are supposed to exist in total.


Extra wad directories, which are left over from the insertion of additional lumps into wad files, in this case probably the music lump, are not unusual in my experience.

WAD is a very open format which can contain arbitrary data between the offset-referenced portions of the files (the directory and the lumps). The only thing fixed is the position of the header, which should be at offset 0. Directories which are not referenced from the header are only interlump garbage and must always be ignored.

Your problem with reading the directory may be because the lump names are empty, which is something that needs to be tolerated - I know for a fact that this is not nearly the only wad with empty lump names in the directory.

Old Post 04-05-10 20:59 #
Quasar is offline Profile || Blog || PM || Email || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
Gez
Why don't I have a custom title by now?!


Posts: 7046
Registered: 07-07


Nah, I've found and fixed the issue already, that wasn't that. :)

Because of the way the Slade 3 identification algorithm is written, if loading the MemChunk failed, then the rest of the setup continued with the data from the previous lump...

Old Post 04-05-10 21:15 #
Gez is offline Profile || Blog || PM || Search || Add Buddy IP || Edit/Delete || Quote
Quasar
Moderator


Posts: 4615
Registered: 08-00



Gez said:
Nah, I've found and fixed the issue already, that wasn't that. :)

Because of the way the Slade 3 identification algorithm is written, if loading the MemChunk failed, then the rest of the setup continued with the data from the previous lump...


Ahh, woops :) Good to hear you got it fixed.

Old Post 04-05-10 23:53 #
Quasar is offline Profile || Blog || PM || Email || Homepage || Search || Add Buddy IP || Edit/Delete || Quote
All times are GMT. The time now is 02:21. Post New Thread    Post A Reply
 
Doomworld Forums : Powered by vBulletin version 2.2.5 Doomworld Forums > Classic Doom > Source Ports > MUS Format Recommendation

Show Printable Version | Email this Page | Subscribe to this Thread

 

Forum Rules:
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is OFF
vB code is ON
Smilies are OFF
[IMG] code is ON
 

< Contact Us - Doomworld >

Powered by: vBulletin Version 2.2.5
Copyright ©2000, 2001, Jelsoft Enterprises Limited.

Forums Directory