Gez
Why don't I have a custom title by now?!
Posts: 7046
Registered: 07-07 |
VortexCortex said:
Seriously, do you think a company stays profitable SELLING top end graphics hardware that is utterly broken?
(wow, just....wow)
What matters is Direct3D. OpenGL plays second fiddle. This is becoming more and more true given that now games are no longer developed for the PC, but for the Xbox (aka "DirectX box") and then just haphazardly and half-heartedly ported to the PC with a shit-ton of DRM crippleware built-in just so as to lament about how PC gamers are a bunch of nasty pirates.
VortexCortex said:
Even other games (like Spleen mentioned glboom+) which do things very similar to the way Graf's engine does things work fine
But you said it was a completely flawed way to do things, just a "proof of concept" code, and it would have to be reworked from the ground up with mainstream methods.
VortexCortex said:
I saw the hoards of evil memory munching bugs lurking just out of everyone else's sight, and I didn't run for the hills...
Two functions are not a horde.
VortexCortex said:
(It's not so much the memory leaks, but using pointers to ram that's been freed, and using variables without initializing them first -- that's C 101, chapter 1 page 1, first paragraph: Using Variables!).
Your valgrind report says there's a variable used without initialization in this function:
code:
bool SafeCheckRange(angle_t startAngle, angle_t endAngle)
{
if(startAngle > endAngle)
{
return (IsRangeVisible(startAngle, ANGLE_MAX) || IsRangeVisible(0, endAngle));
}
return IsRangeVisible(startAngle, endAngle);
}
So... I find it hard to believe that they are not actually initialized. Going up the chain of calls doesn't make it more likely that the values that are passed as parameters could actually be not initialized -- we're talking about vertex position, if they weren't set to what they're supposed to be the geometry wouldn't even be right. Given that there are evidence that your report is actually about Skulltag and not any recent version of GZDoom, that makes your allegations of bugs irrelevant at best -- this is your problem, not Graf's anymore.
|
04-14-10 09:17 
