Does zdbsp generate nodes incorrectly?

Doomworld Forums : Powered by vBulletin version 2.2.5

Doomworld Forums > Classic Doom > Source Ports > Does zdbsp generate nodes incorrectly?

Author

All times are GMT. The time now is 11:31.

entryway
Forum Staple

Posts: 2666
Registered: 01-04

I have made test map to check a possibility of some overflows in prboom-plus. The map contains 65536+ sidedefs (which are compressed to 95)

deepbsp version with its extended nodes (xNd4 magic) works perfectly. zdbsp version (XNOD magic) is a full mess.

I tried to build nodes with the latest zdbsp for sunder.wad map11 (it requires extended nodes) and there are no problems with that map in prboom-plus. It's strange, because both maps use the same format of nodes. Sunder works, but test level does not.

I am using zdbsp 1.15 release. Command line is: zdbsp -X test241.wad

Last edited by entryway on 06-22-10 at 16:46

06-22-10 14:59 #

Profile || Blog || PM || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

entryway
Forum Staple

Posts: 2666
Registered: 01-04

Ok, probably something is broken in prboom-plus. I have reduced lines number to make map_vertex_count + zdbsp_additional_vertex_count < 65536 and all is ok now.

06-22-10 17:02 #

Profile || Blog || PM || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

TheDarkArchon
Forum Staple

Posts: 2320
Registered: 08-04

GZDoom has to rebuild the nodes on ZDBSP built nodes, stating the BSP tree is incomplete, but when it rebuilds, it runs fine.

06-22-10 17:32 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

entryway
Forum Staple

Posts: 2666
Registered: 01-04

TheDarkArchon said:
GZDoom has to rebuild the nodes on ZDBSP built nodes, stating the BSP tree is incomplete, but when it rebuilds, it runs fine.

Yes, it even does not try to load them, because of

code:UsingGLNodes = true;
if (map->MapLumps[ML_ZNODES].Size != 0 && !UsingGLNodes)
{
  idcheck2 = MAKE_ID('X','N','O','D');

Looks like prboom-plus has dependence from number of vertexes, because vertexes count is 65534 map vertexes + 4357 extra vertices by zdbsp > MAX_USHORT. deepbsp does not generate additional vertexes and that's why deepbsp version works fine. Currently I do not know how to fix it.

btw, svn Eternity can't handle test241_zdbsp.wad correctly too.

Last edited by entryway on 06-22-10 at 19:54

06-22-10 17:53 #

Profile || Blog || PM || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

Quasar
Moderator

Posts: 5148
Registered: 08-00

entryway said:

Yes, it even does not try to load them, because of
code:UsingGLNodes = true;
if (map->MapLumps[ML_ZNODES].Size != 0 && !UsingGLNodes)
{
  idcheck2 = MAKE_ID('X','N','O','D');
Looks like prboom-plus has dependence from number of vertexes, because vertexes count is 65534 map vertexes + 4357 extra vertices by zdbsp > MAX_USHORT. deepbsp does not generate additional vertexes and that's why deepbsp version works fine. Currently I do not know how to fix it.

btw, svn Eternity can't handle test241_zdbsp.wad correctly too.

Loverly. Let me know if anything is figured out with respect to this. I'm knee-deep in DECORATE states right now ;)

06-22-10 21:13 #

Profile || Blog || PM || Email || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

Gez
Why don't I have a custom title by now?!

Posts: 9148
Registered: 07-07

Map is broken in ZDoom too. The test map is one that ZDBSP has trouble processing apparently.

06-22-10 21:26 #

Profile || Blog || PM || Search || Add Buddy

IP || Edit/Delete || Quote

entryway
Forum Staple

Posts: 2666
Registered: 01-04

Gez said:
Map is broken in ZDoom too. The test map is one that ZDBSP has trouble processing apparently.

How did you test? For me it works with zdoom

EDIT: map works fine with zdoom 2.4.1 (because 2.4.1 did not support XNOD?), but does not work with svn build

Last edited by entryway on 06-22-10 at 21:55

06-22-10 21:31 #

Profile || Blog || PM || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

TheDarkArchon
Forum Staple

Posts: 2320
Registered: 08-04

Breaks on ZDoom r2351 but rebuilding the nodes using ZDooms internal nodebuilder (Which ZDBSP is based on) works.

06-22-10 21:54 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

entryway
Forum Staple

Posts: 2666
Registered: 01-04

TheDarkArchon said:
Breaks on ZDoom r2351 but rebuilding the nodes using ZDooms internal nodebuilder (Which ZDBSP is based on) works.

r2351?

Revision: 2351
----
Modified : /zdoom/trunk/src/g_shared/sbarinfo.cpp
Modified : /zdoom/trunk/src/g_shared/sbarinfo_commands.cpp
Modified : /zdoom/trunk/wadsrc/static/sbarinfo/doom.txt

06-22-10 21:58 #

Profile || Blog || PM || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

Gez
Why don't I have a custom title by now?!

Posts: 9148
Registered: 07-07

entryway said:
EDIT: map works fine with zdoom 2.4.1 (because 2.4.1 did not support XNOD?)

Exactly. The nodes are unrecognized and therefore rebuilt. It works fine when nodes are internally rebuilt, but not when using nodes generated with zdbsp -X.