Doomworld Forums - chocorenderlimits Platform count fix

Doomworld Forums : Powered by vBulletin version 2.2.5

Doomworld Forums > Classic Doom > Source Ports > chocorenderlimits Platform count fix

Author

All times are GMT. The time now is 05:00.

Whoo
Forum Regular

Posts: 673
Registered: 04-07

Mappers in TNT 2 noticed that chocorenderlimits wasn't counting the number of active platforms, but rather the total number activated.

So I went into the source and fixed it.

The problem was located in p_plats.c, in the P_RemoveActivePlat function. The P_AddActivePlat function was adding to the total number of platforms, but P_RemoveActivePlat wasn't removing the active ones. Here is the modified p_plats.c file.

Last edited by Whoo on 12-31-11 at 00:50

12-24-11 22:12 #

Profile || Blog || PM || Search || Add Buddy

IP || Edit/Delete || Quote

Enjay
ASK ME ABOUT FOOTBALL / STEAM / DEAD CELEBRITIES / THE BLAIR WITCH PROJECT

Posts: 5596
Registered: 12-00

Hmmm... when I try to run it I get:

http://i.imgur.com/qMc3L.png

The Event log says:

Activation context generation failed for "C:\Doom\Chocorenderlimits\chocorenderlimits_platfix.exe". Dependent Assembly Microsoft.VC90.DebugCRT,processorArchitecture="x86",publicKeyToken="1fc8b3b9a1e18e3b",type="win32",version="9.0.21022.8" could not be found.

I'm not sure how to run sxstrace.exe to get meaningful output so that's everything that I have.

12-30-11 12:27 #

Profile || Blog || PM || Email || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

Graf Zahl
Why don't I have a custom title by now?!

Posts: 7130
Registered: 01-03

People should stop assuming that the VC runtime DLLs are available on their target systems. Microsoft sure made it extremely inconvenient to use those at all... :(

12-30-11 13:04 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

Quasar
Moderator

Posts: 4615
Registered: 08-00

God that's the worst error message since the THORAC-25 fried some people to death while printing out random numbers.

Why the fuck can't they at least print the goddamn file name in there. Jesus Christ on a corndog stick.

Anyway, as Graf says this is a runtime problem (msvcr90.dll probably). However, if you look closely, it is wanting the DebugCRT and that only comes with Visual Studio AFAIK. Only release builds should be distributed to non-programmer users.

12-30-11 16:07 #

Profile || Blog || PM || Email || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

chungy
Doomworld is so about bullshit excuses

Posts: 1458
Registered: 06-05

I've just rebuilt it with mingw32 instead, no MSVC runtime dependencies. http://dl.dropbox.com/u/13513277/ch...its_platfix.zip

12-30-11 21:17 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

Enjay
ASK ME ABOUT FOOTBALL / STEAM / DEAD CELEBRITIES / THE BLAIR WITCH PROJECT

Posts: 5596
Registered: 12-00

Yup, that seems to work. Thank you kindly. :)

12-31-11 00:22 #

Profile || Blog || PM || Email || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

The Green Herring
Community Chest 4 Leader

Posts: 958
Registered: 05-07

It might be just me, but it seems you can't use visplane bordering, sneak mode, or the color change function for the HOM detector anymore. All I get are the Save Game menu, the message toggle function, and the "Quit Game?" prompt, respectively. This was using chungy's build. That one wasn't based on an older version, was it?

__________________
- The Green Herring

12-31-11 01:05 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

Whoo
Forum Regular

Posts: 673
Registered: 04-07

Graf Zahl said:
People should stop assuming that the VC runtime DLLs are available on their target systems. Microsoft sure made it extremely inconvenient to use those at all... :(

Yeah I forgot about the incompatibility problems and I never got around to rebuilding it with Qt or another multi-platform compiler.

chungy said:
I've just rebuilt it with mingw32 instead, no MSVC runtime dependencies. http://dl.dropbox.com/u/13513277/ch...its_platfix.zip

Thanks for building it with a more friendly compiler!

The Green Herring said:
It might be just me, but it seems you can't use visplane bordering, sneak mode, or the color change function for the HOM detector anymore. All I get are the Save Game menu, the message toggle function, and the "Quit Game?" prompt, respectively. This was using chungy's build. That one wasn't based on an older version, was it?

It looks like chungy and I both used source code from the SVN then, and according to the ChangeLog the SVN hasn't been updated since January. I (or chungy) will have to rebuild it with the patch file from ReMood's site.

12-31-11 03:51 #

Profile || Blog || PM || Search || Add Buddy

IP || Edit/Delete || Quote

chungy
Doomworld is so about bullshit excuses

Posts: 1458
Registered: 06-05

Indeed; I made the build rather quickly without noticing that Ghostly had a patch of further changes than what is in Subversion. I've just updated the same Zip file with the later changes and Whoo's combined.

12-31-11 04:35 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

GhostlyDeath
Forum Retard

Posts: 829
Registered: 08-05

The SVN has not been updated because I switch to mercurial! Also Fraggle has stopped bothering patching his copy. So if fraggle is reading this, you could potentially delete that branch and just tell everyone to go to this URL instead, perhaps with a single file in it.

https://bitbucket.org/GhostlyDeath/...limits/overview

The actual repo is: https://bitbucket.org/GhostlyDeath/chocorenderlimits

EDIT: If you give me an ACTUAL patch and not an individual file, I will gladly apply it so it would work in a future version of Chocorenderlimits.

Last edited by GhostlyDeath on 12-31-11 at 04:54

12-31-11 04:48 #

Profile || Blog || PM || Homepage || Search || Add Buddy

IP || Edit/Delete || Quote

chungy
Doomworld is so about bullshit excuses

Posts: 1458
Registered: 06-05

It's a one-line change, really, nothing complicated. (Though you've apparently re-indented the source on bitbucket to your own preferences (I must say, tabs, yuck), so simply diffing his big file would have been difficult)

code:diff -r 45dcb675005c src/p_plats.c
--- a/src/p_plats.c	Wed Oct 05 13:17:02 2011 -0400
+++ b/src/p_plats.c	Fri Dec 30 21:13:38 2011 -0800
@@ -297,6 +297,7 @@
 			P_RemoveThinker(&(activeplats[i])->thinker);
 			activeplats[i] = NULL;
 			
+			numplats--;
 			return;
 		}
 	I_Error("P_RemoveActivePlat: can't find plat!");

12-31-11 05:15 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote

Graf Zahl
Why don't I have a custom title by now?!

Posts: 7130
Registered: 01-03

Whoo said:

Yeah I forgot about the incompatibility problems and I never got around to rebuilding it with Qt or another multi-platform compiler.

The compiler isn't the problem. Just the settings for the runtime library. For simple applications setting it to 'static' is absolutely recommended.

12-31-11 09:46 #

Profile || Blog || PM || Email || Search || Add Buddy

IP || Edit/Delete || Quote