how to get thingcountname to work?

4 hours ago, zzzornbringer said:

this should be very easy but it just doesn't work. it always returns 0 no matter what.

 

what am i doing wrong?

 

edit: i have isolated the problem. it's smooth doom.

Because SmoothDoom is doing this:

• ACTOR SmoothDoomImp : DoomImp Replaces DoomImp

https://zdoom.org/wiki/DECORATE tells all.  :-)

4 hours ago, zzzornbringer said:

edit: i have isolated the problem. it's smooth doom.

Welcome to the wonderful world of pairing GZDoom scripts with mods! It's amazing how quickly compatibility breaks.

My hunch would be Smooth Doom has replaced DoomImp with a differently named actor. If you load SmoothDoom, point at an Imp, bring down the console and type "Info" it will tell you what the new monster is.

Edit: Damn, ninjad by Kappes while I was trying to remember the "Info" command!

2 hours ago, Kappes Buur said:

 

Because SmoothDoom is doing this:

• ACTOR SmoothDoomImp : DoomImp Replaces DoomImp

 

https://zdoom.org/wiki/DECORATE tells all.  :-)

little bit off-topic but is this even necessary? couldn't you just use the regular actor "doomimp" if your new actor replaces it anyways? i mean, the actor will inherit the original values anyways?!

Sorry to refresh that topic, but I've got a similar problem like zzzornbringer which fits in here. 

Scenario: 

You walk over a linedef that triggers 10 lost souls to spawn around you. Quite easy so far, just use the famous "135" linedef action for the easy way.

Now I want them to be killed (condition) to lower a barrier so you could reach the exit. I tried a different way and don't know why the new thing ID seems not to be working in a script. I wanted to combine the linedef action with a plain 80-execute script and that's probably the trouble. Those lost souls should get a new thing ID (172) after they arrived at their teleport destination (171). The third script already includes the new thing ID 172 and I thought it should do the trick then, because all lost souls are physically there with that damn number. I even named them in the script specifically, but no.....nothing happens.

What is the conflict here?? (Using GZDB BF3045 / UDMF by the way)

how do you execute script 3? i don't see where you trigger it. 

i'd do it like this: instead of the spawn thing action, use action 80 to execute your script. add the spawn function to that script. i use personally use spawnspotforcedfacing. however if you use this function, you need to spawn the teleporter fog separately. or just use spawn_thing. it's basically the same.

i also recommend using thingcountname. it's easier for me, because i don't have to remember the exact name definitions. you can use the names that are used in the editor. for example: "doomimp" instead of T_IMP. easier to remember imho. but that's just a suggestion. both functions work identical.

i'd also add a print function: print (d:thingcount(T_LOSTSOUL, 172));

so you can see that it actually counts correctly. that's just for testing obviously.

1 hour ago, zzzornbringer said:

how do you execute script 3? i don't see where you trigger it. 

Yeah, that's exactly the weird part. Usually, it's simple. You give an enemy the action trigger 80 and the corresponding script number. When it dies, sth. happens. The script itself wasn't compiled with errors and also works when I place lost souls directly with teir tags. It apparently doesn't work with a teleport destination that spawns lost souls with a TID that isn't on the map (yet). I didn't know how to set a trigger on something that doesn't exist yet. I desperately gave the teleport destination the trigger function but that was foolish either. I guess I have to do it your way then and script the whole thing like you did above or try something else. 

Edit:

Yep, it works... finally. I "stole" your script and adjusted it a little bit. It all could be so easy if you knew it. 

Scripting might kill me one day, LoL

 Thanks !!!!

You don't need to set a trigger on them at all. Use a script to spawn the monsters at a given mapspot, and then in that same script, enter a loop that checks for when those monsters are all dead. Once dead, do something. One script does it all.

Script 3 (void)

{

  Thing_SpawnFacing(666, T_LOSTSOUL, FALSE, 172);  // Spawn lost souls with TID 172 at each mapspot with TID 666.

  While (Thing_Count(T_LOSTSOUL, 172)) Delay(1);  // If the number of lost souls with TID 172 is non-zero, delay for a tic.

  Plat_DownWaitUpStay(300, 3, 0); // Do the plat thing.

}

Also, you should use mapspots, not teleport destinations, and using the "Facing" version of a special/function will allow your lost souls to spawn facing the directions of your mapspots (in case you want them to surround the player, facing inwards).

1 hour ago, 4everDoomed said:

 

I didn't know how to set a trigger on something that doesn't exist yet.

 

 

i think this may come in handy:

https://zdoom.org/wiki/Thing_SetSpecial

but the way you did it already also does the job and is actually easier imho. but if you often use scripts to spawn things, this function may be useful to you.

Thanks again ! 

I tried it on a test.wad that I created for my "experimental needs" :-)))

Just a slight mistake though, it has to be written "ThingCount" instead of Thing_Count but that could also depend on different Doombuilders or whatever...

Nevertheless, it works and I'll switch over to mapspots in the future like you recommended. 

2 hours ago, EarthQuake said:

You don't need to set a trigger on them at all. Use a script to spawn the monsters at a given mapspot, and then in that same script, enter a loop that checks for when those monsters are all dead. Once dead, do something. One script does it all.

 

Script 3 (void)

{

  Thing_SpawnFacing(666, T_LOSTSOUL, FALSE, 172);  // Spawn lost souls with TID 172 at each mapspot with TID 666.

  While (Thing_Count(T_LOSTSOUL, 172)) Delay(1);  // If the number of lost souls with TID 172 is non-zero, delay for a tic.

  Plat_DownWaitUpStay(300, 3, 0); // Do the plat thing.

}

 

Also, you should use mapspots, not teleport destinations, and using the "Facing" version of a special/function will allow your lost souls to spawn facing the directions of your mapspots (in case you want them to surround the player, facing inwards).

_______

2 hours ago, zzzornbringer said:

 

i think this may come in handy:

https://zdoom.org/wiki/Thing_SetSpecial

 

but the way you did it already also does the job and is actually easier imho. but if you often use scripts to spawn things, this function may be useful to you.

I'll try that one out, too.

Thanks for all your suggestions, it helped a lot and was better than what I tried. 

19 minutes ago, 4everDoomed said:

Just a slight mistake though, it has to be written "ThingCount" instead of Thing_Count but that could also depend on different Doombuilders or whatever...

Ahh, sorry, my mistake. Too many function and special names that all look like each other. :)

nvm. one bracket was misplaced.