Doom source code oddity.

I was looking through r_segs.c in the source code and noticed something odd. Take a close look, especially at third 'if' block.

// two sided line
if (toptexture)
{
// top wall
mid = pixhigh>>HEIGHTBITS;
pixhigh += pixhighstep;

if (mid >= floorclip[rw_x])
    mid = floorclip[rw_x]-1;
	
if (mid >= yl)
{
    dc_yl = yl;
    dc_yh = mid;
    dc_texturemid = rw_toptexturemid;
    dc_source = R_GetColumn(toptexture,texturecolumn);
    colfunc ();
    ceilingclip[rw_x] = mid;
}
else
    ceilingclip[rw_x] = yl-1;
}
else
{
// no top wall
if (markceiling)
    ceilingclip[rw_x] = yl-1;
}
	
if (bottomtexture)
{
// bottom wall
mid = (pixlow+HEIGHTUNIT-1)>>HEIGHTBITS;
pixlow += pixlowstep;

That way of rendering always boggled my mind, but I never noticed they'd stumbled upon something way ahead of their time. Carmack truly was (and of course still is) a genius. But it seems even he wasn't aware how smart he was!

Still don't see it? Here's a hint.

Its April already?

No, that's just when this part of the source was written in '93.

By golly who'd ever knew that source code could be the object of such a wondrously funny jape. Damn good show I say!

Posting in this thread for no good reason.





Also... Headcrabs.

idgi

Reading source code for me is like reading Latin. Looks cool, but makes no sense :P

baronofheck82 said:

Reading source code for me is like reading Latin. Looks cool, but makes no sense :P

My current favorite chunk:

for(shift = 28; shift >= 0; shift -= 4)
   *c++ = "0123456789abcdef"[(hash->digest[i] >> shift) & 0x0F];

Quasar said:

for(shift = 28; shift >= 0; shift -= 4)
   *c++ = "0123456789abcdef"[(hash->digest[i] >> shift) & 0x0F];

Is that from Doom? It looks like some kind of integer to hex string conversion.

baronofheck82 said:

Reading source code for me is like reading Latin.

I'd say reading other peoples source code is like reading Latin.

I guess you have to be smart to get it.

Welp :(

Scet said:

Is that from Doom? It looks like some kind of integer to hex string conversion.

It's from EE, of course. Recent revisions have been on a branch where many arrays are being converted to hashes. There aren't many hashes in vanilla Doom...