Jump to content
Search In
  • More options...
Find results that contain...
Find results in...
Doomkid

Automated way to check if a wad has unmodified id resources?

Recommended Posts

A lot of wads get rejected from idgames on the first attempt due to using unmodified id resources. It seems there's some automated process by which each lump is checked against the lumps in the iwads, which totally makes sense, however it results in a wad being rejected if one tiny lump is accidentally included without alteration.

 

Is there some automated way to check this? I think it would result in less headaches all around.

Share this post


Link to post

I too would be interested. I've been told Slade does this, but attempts to make this trigger by intentionally including a vanilla patch didn't generate a warning.

Share this post


Link to post

That is an excellent feature. Is there some way you can get it to identify duplicated lumps without necessarily deleting them in case it's an instance where the lumps are necessary? For example when sprites are partially replaced in a vanilla-compatible wad. If so, what I need already exists in full!

Share this post


Link to post

Not at the moment, sorry. I suppose it could be changed to show a confirmation list with checkboxes like the maintenance feature to remove unused textures.

Share this post


Link to post

anyway, i already wrote a simple utility to do such checks. now i only have to add some options, and build windows binary. so maybe i'll release it somewhere in october, 2057.

Share this post


Link to post
4 hours ago, Doomkid said:

That is an excellent feature. Is there some way you can get it to identify duplicated lumps without necessarily deleting them in case it's an instance where the lumps are necessary? For example when sprites are partially replaced in a vanilla-compatible wad. If so, what I need already exists in full!

You can just copy and paste the list it gives you into Notepad or something and then don't save the changes to the WAD afterward.
 

Share this post


Link to post

wadcheck v0.000000 ;-) README is inside the archive. sources will eventually be put in k8vavoom repo. done.

 

wadcheck_540413.7z

 

p.s.: it is not limited to iwads: it works by creating a database of known lumps, and then checks if lump is in database. i.e. you can create a database for any wad/pk3, and check any other wad/pk3 against it. of course, database can contain info for more than one "known wad", and the utility will show you properly attributed lump names.

 

as it uses hashing internally, there is some small chance of false positives. in practice, it should be so rare that it is irrelevant.

 

p.p.s.: the utility is quite dumb at the moment. maybe i'll add checking for "borrowed maps" later (i.e. it will check map geometry and report matches for it), some additional flags to ignore some lump types and such. dunno if somebody will need that, tho. anyway, enjoy.

Edited by ketmar

Share this post


Link to post

you're welcome. it wasn't heavily tested, so don't hesitate to report any bugs or things you'd like to see added/improved. i won't making any promises for some complex changes, but who knows... ;-)

Share this post


Link to post

put sources to k8vavoom repository. not that anybody will be able to build it out of the box, but anyway...

Share this post


Link to post

It would be kind of cool if it could also use a locality sensitive hash function in order to detect derivative works (recolors, altered sprites, sector copy and pastes, etc) probabilistically. That would require a bunch more work though and probably not be very popular in its application.

Share this post


Link to post

i thought about that, bit it wasn't requested. it can be fun statistics, but tbh i don't see alot of other value in it besides being fun. and for sheer fun factor it is too much code, sorry. in the current form i just took some code from k8vavoom, and that is basically all of it.

Share this post


Link to post

Sorry for the bump, but I kind of think ketmar’s tool should be mentioned in the “how to idgames” thread from 2005. A veritable fuckton of wads seem to be getting rejected lately for containing iwad resources, a readily available solution to this problem should be made obvious so as not to deter newbie modders from using idgames. Just a thought!

Share this post


Link to post

then i prolly should upload update with small bugfixes. will do that soon.

Share this post


Link to post

ok, i replaced old version with slightly updated one. fixes are mostly cosmetics (but zip/lzma unpacker had bugs too), database format wasn't changed. output format slightly changed, tho. if you wrote some tools to parse old output format, use "--long" option to restore old output. have fun.

Share this post


Link to post
8 hours ago, Doomkid said:

Sorry for the bump, but I kind of think ketmar’s tool should be mentioned in the “how to idgames” thread from 2005. A veritable fuckton of wads seem to be getting rejected lately for containing iwad resources, a readily available solution to this problem should be made obvious so as not to deter newbie modders from using idgames. Just a thought!

On the subject of rejected idgames uploads, is this where it shows em all? http://www.gamers.org/pub/idgames/REJECTS

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×