WhackEd 4

[maxmanium]

3 minutes ago, exl said:

 

I'm not sure, it is trying to load one of the button graphic resources but can't read or find them. What location did you install it to, the default of "Program Files (x86)\WhackEd4"?

 

No, I have it installed in my Doom folder which is just under C:\.

[URROVA]

Hello, i open Whacked4 and shows me this giant error:

src\whacked4\ui\windows.py:233: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:235: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:237: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:239: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:241: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:243: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:245: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:247: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:249: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
Traceback (most recent call last):
  File "src\whacked4\app.py", line 60, in OnInit
  File "src\whacked4\ui\mainwindow.py", line 54, in __init__
  File "src\whacked4\ui\editors\statesframe.py", line 63, in __init__
  File "src\whacked4\ui\windows.py", line 1942, in __init__
  File "src\whacked4\ui\spritepreview.py", line 35, in __init__
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(LC_ALL, NULL), "C") == 0" failed at ..\..\src\common\intl.cpp(1579) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Things are going to break, please only change locale by creating wxLocale objects to avoid this!
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'

I have python 3.7 installed on the pc. Could it affect the program in any way?

[exl]

It uses its own Python version, so that should not be the cause. It is trying to open up the Thing editor window but there's no patch loaded... What version are you using and what do you do exactly to trigger that error?

[JXC]

Hey, DoomRetro and Crispy Doom recently have been updated to have a few Extended DeHackEd features dehardcoded. Is there any chance you will make them visible in the WhackEd4 editor? Doom Retro has additional parameters like floatbob and blood color that I don't see in the editor.

[exl]

It's on my todo list to add those, and especially to look closer at the extended Dehacked stuff. But when that will be I don't know. Weird and busy times. In the meantime, I'll gladly look at patches submitted through Github.

[URROVA]

On 6/1/2020 at 4:13 AM, exl said:

It uses its own Python version, so that should not be the cause. It is trying to open up the Thing editor window but there's no patch loaded... What version are you using and what do you do exactly to trigger that error?

Ok, the error triggers when i just open the program. I'm using the version 1.2.4 (the most recent).

 

I tried 1.2.3 and this works! But 1.2.4 spits that error :/

[exl]

@URROVA does this modified version work? http://www.teamhellspawn.com/exl/whacked4/files/whacked4-setup-1.2.4-interim.exe for the installer or http://www.teamhellspawn.com/exl/whacked4/files/whacked4-1.2.4-interim.7z for the archive.

[URROVA]

21 hours ago, exl said:

@URROVA does this modified version work? http://www.teamhellspawn.com/exl/whacked4/files/whacked4-setup-1.2.4-interim.exe for the installer or http://www.teamhellspawn.com/exl/whacked4/files/whacked4-1.2.4-interim.7z for the archive.

Yes, it runs and works normally!! Thank you :)

[Altazimuth]

A friend found an issue in WhackEd with vanilla strings. The length limiting is incorrect. The maximum number of characters in a string should be defined by the first number after the "Text" label. That number is passed into the below function from Chocolate Doom:

Spoiler

static int TXT_MaxStringLength(int len)
{
    // Enough bytes for the string and the NUL terminator

    len += 1;

    // All strings in doom.exe are on 4-byte boundaries, so we may be able
    // to support a slightly longer string.
    // Extend up to the next 4-byte boundary

    len += (4 - (len % 4)) % 4;
            
    // Less one for the NUL terminator.

    return len - 1;
}

 

 

[Stupid Bunny]

On 9/10/2020 at 11:53 AM, exl said:

@URROVA does this modified version work? http://www.teamhellspawn.com/exl/whacked4/files/whacked4-setup-1.2.4-interim.exe for the installer or http://www.teamhellspawn.com/exl/whacked4/files/whacked4-1.2.4-interim.7z for the archive.

 

I tried installing this interim version, and I'm still popping this error whenever I try to open one of my .deh files:

src\whacked4\ui\windows.py:233: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:235: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:237: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:239: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:241: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:243: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:245: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:247: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:249: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:2273: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:3522: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:3524: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:3936: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:3938: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
Traceback (most recent call last):
  File "src\whacked4\app.py", line 68, in OnInit
  File "src\whacked4\ui\mainwindow.py", line 232, in open_file
  File "src\whacked4\dehacked\patch.py", line 590, in read_dehacked
TypeError: list indices must be integers or slices, not str

 

The .deh was created with the same version of WhackEd that it's failing to open in, for Doom v1.9 and DOOM2 as the IWAD.  I made minor modifications to the .deh file in Notepad++ before it started doing this but I'm not sure if that's relevant.

 

I also tried getting rid of the .whacked file associated with the .deh, and now it will prompt me when I open it; but it doesn't show Doom or Ultimate Doom 1.9 as available options.  This is true in both the normal and interim 1.2.4 versions.

 

Let me know if you need any more information.  In the meantime, do you have suggestions for how I might get around this?  I have a bunch of dehacked work I want to do and I can't do it with these errors popping.  If all else fails I might see if I can find 1.2.3 or another older version.

[exl]

Would it be possible to see the patch file itself?

[Stupid Bunny]

11 minutes ago, exl said:

Would it be possible to see the patch file itself?

 

Sure, I'll DM you a link to it.

 

BUT I think I know what the problem was.  I had added a ZDoom obituary string, manually, in Notepad++, which given that the patch had been saved as a Doom 1.9 deh probably confused WhackEd due to the sudden compatibility breakage.  It also explains why I couldn't open it in 1.9 mode when I downgraded to 1.2.3, which is what I'm currently using.  I'll also point you to this other error I often get when saving or opening a patch that doesn't crash the program, but still worries me a bit when I see it.

[exl]

23 hours ago, StupidBunny said:

Sure, I'll DM you a link to it.

 

Thanks for sending it. It does indeed load fine on my end, which makes sense. It won't like things that are not compatible with the engine config you load it with. It should give better feedback about that though.

 

[zeldavxa]

Id liek to do a patch for Doom 1/Chex, but no matter what configuration i pick i get Doom 2 item id's and frames... is there a way to omit them so i can ensure i ain't trying to make the vanilla exe load things that don't exist?

[Xaser]

Hey @exl, a few of us have been cooking up a new compatibility standard called MBF21 (with full support in the latest dsda-doom release so it's a real thing ;), and it's got a load of new DEHACKED features. What are your thoughts on adding support for this in WHackEd4? We're seeing about getting the new features supported in as many ports+tools as possible, to try and get "Boom" mapping out of the stone age. ;)

[exl]

Interesting stuff. I plan to add support for it, at some point. It is on my todo list at any rate. Some hairy work to support multiple flag fields will be needed, which is something I've been putting off for a while now.

[floatRand]

Thanks for maintaining WHackEd4 so far! I would really appreciate the support of mbf21 personally since the tool in particular is my primary way of doing dehackery. 

 

[Christian Ck.]

.

 

Edited June 15, 2023 by Christian Ck.

[exl]

That one seems hard to reproduce, but I'll include a safeguard against that in the next version. No ETA on that though.

[exl]

Version 1.3.0 is available as a beta release. The biggest new features are full support for all of Doom Retro's and DEHEXTRA's new properties and flags. This also paves the way for future MBF21 support, but more work is needed for that. Behind the scenes the engine and table configuration file format has changed to aid maintainability and allow them to extend each other. If you have any such custom configuration files, they will need to be updated.

 

The full changelog:

• Added: support for DEHEXTRA thing fields: Gib health, Dropped item, Pickup width, Projectile pass height and Fullbright.
• Added: support for DEHEXTRA extra sounds.
• Added: Doom Retro thing fields: Blood, Shadow offset, Retro Bits, Name and Plural.
• Added: better Linux compatibility. The application starts and is somewhat usable, but a number of UI issues still prevent it from working well.
• Added: state preview now uses a state's unused 1 and 2 parameters as offsets if previewing a state from the weapons editor (right-click state label).
• Changed: engine table files can now include (base table) files. This leads to smaller filesizes and makes for easier updating. As a result of this, strings in the Doom 1.9 and Ultimate Doom 1.9 tables are now keyed by their index.
• Changed: engine table files list only fields used by that engine to reduce their size and improve maintainability. Default entries for things, states, weapons, ammo and sounds are provided for tables that extend existing ones.
• Changed: string editing for vanilla patches will allow any number of characters to be entered, but disallow using the new string if it is too long.
• Changed: thing editor properties, states, sounds and flags are now tabbed to save on screen real estate. Especially useful if an engine has many thing properties.
• Changed: WhackEd4 is now a 64 bit application.
• Fixed: the state animation preview now displays action names instead of code pointers for non-extended patches.
• Fixed: a weapon's FireCGun and FirePlasma actions would only mark the extra muzzle flash state as used if the action was used on the first fire state.
• Fixed: loading non-extended patches that try to set a codepointer on a state that originally had none will now display a warning. Thanks to Zodomaniac.
• Fixed: saving a yet unsaved patch while exiting caused a crash. Thanks to TheStupidestBeing.
• Fixed: BEX strings that do not appear in the engine selected for a patch will now not be visible in the strings editor, but will remain in the saved patch.
• Fixed: fixed a wrong next state value in the MBF tables for S_GRENADE (968). Thanks to hawkwind3.
• Fixed: crash on startup in some rare cases where no patch was loaded yet. Thanks to Endy McGufin.
• Fixed: maximum string length calculation for non-extended patches did not take the terminating NULL character into account. Thanks to Altazimuth.
• Fixed: sprite frame selection up\down button did not work correctly.
• Fixed: sound priority values can now be in the full signed integer range (though anything above 127 is useless). https://github.com/GitExl/WhackEd4/issues/12

Setup executable (13 Mb): https://www.teamhellspawn.com/exl/whacked4/files/whacked4-setup-1.3.0-beta.exe

Standalone 7zip archive (11 Mb): https://www.teamhellspawn.com/exl/whacked4/files/whacked4-1.3.0-beta.7z

Edited June 20, 2021 by exl

[Doomkid]

This is an awesome update!

[SuperPIter_DoomWorldthe2nd]

2 hours ago, exl said:

Setup executable (13 Mb): http://www.teamhellspawn.com/exl/whacked4/files/whacked4-setup-1.3.0-beta.exe

Standalone 7zip archive (11 Mb): http://www.teamhellspawn.com/exl/whacked4/files/whacked4-1.3.0-beta.7z

You might wanna fix those URLs, since Google ABSOLUTELY refuses to download anything from links with http: instead of https:

[VGA]

Get a proper browser, the links are good :D

[exl]

I updated the links a while ago, didn't realise HTTPS is supported by Team Hellspawn now.

[Warden]

The 1.3.0 beta gives me a "missing api-ms-win-core-path-l1-1-0.dll" error on launch, which according to this link might mean Whacked4 no longer supports win7?

https://github.com/microsoft/CNTK/issues/224

[Biz!]

When another beta releases, I recommend bundling the MBF21 spec with it ( makes doom editing much easier, by the way thank you for making dehacked windows compatible )

[exl]

18 hours ago, Redoom said:

When another beta releases, I recommend bundling the MBF21 spec with it ( makes doom editing much easier, by the way thank you for making dehacked windows compatible )

 

That's planned for the next version. This version does include some preparatory work for it.

[Beans]

src\whacked4\ui\windows.py:233: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:235: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:237: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:239: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:241: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:243: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:245: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:247: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:249: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
Traceback (most recent call last):
  File "src\whacked4\app.py", line 60, in OnInit
  File "src\whacked4\ui\mainwindow.py", line 54, in __init__
  File "src\whacked4\ui\editors\statesframe.py", line 63, in __init__
  File "src\whacked4\ui\windows.py", line 1942, in __init__
  File "src\whacked4\ui\spritepreview.py", line 35, in __init__
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(LC_ALL, NULL), "C") == 0" failed at ..\..\src\common\intl.cpp(1579) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Things are going to break, please only change locale by creating wxLocale objects to avoid this!
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'

always get this error while launching whackED

[Beans]

src\whacked4\ui\windows.py:233: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:235: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:237: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:239: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:241: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:243: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:245: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:247: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:249: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
Traceback (most recent call last):
  File "src\whacked4\app.py", line 60, in OnInit
  File "src\whacked4\ui\mainwindow.py", line 54, in __init__
  File "src\whacked4\ui\editors\statesframe.py", line 63, in __init__
  File "src\whacked4\ui\windows.py", line 1942, in __init__
  File "src\whacked4\ui\spritepreview.py", line 35, in __init__
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(LC_ALL, NULL), "C") == 0" failed at ..\..\src\common\intl.cpp(1579) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Things are going to break, please only change locale by creating wxLocale objects to avoid this!
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'
 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

i always get this error while launching whackED

[omx32x]

50 minutes ago, Beans said:

src\whacked4\ui\windows.py:233: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:235: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:237: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:239: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:241: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:243: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:245: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:247: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
src\whacked4\ui\windows.py:249: wxPyDeprecationWarning: Call to deprecated item. Use :meth:`AddTool` instead.
Traceback (most recent call last):
  File "src\whacked4\app.py", line 60, in OnInit
  File "src\whacked4\ui\mainwindow.py", line 54, in __init__
  File "src\whacked4\ui\editors\statesframe.py", line 63, in __init__
  File "src\whacked4\ui\windows.py", line 1942, in __init__
  File "src\whacked4\ui\spritepreview.py", line 35, in __init__
wx._core.wxAssertionError: C++ assertion "strcmp(setlocale(LC_ALL, NULL), "C") == 0" failed at ..\..\src\common\intl.cpp(1579) in wxLocale::GetInfo(): You probably called setlocale() directly instead of using wxLocale and now there is a mismatch between C/C++ and Windows locale.
Things are going to break, please only change locale by creating wxLocale objects to avoid this!
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'
Traceback (most recent call last):
  File "src\whacked4\ui\editors\thingsframe.py", line 314, in activate
  File "src\whacked4\ui\editors\thingsframe.py", line 352, in update_properties
AttributeError: 'NoneType' object has no attribute 'things'
 

 

 

 

 

 

 

 

 

 

 

 

 

 

 

i always get this error while launching whackED

whats your specs and os?