Sign in to follow this  
Followers 0

psxwadgen question

I was reading the changelog (found many amusing or interesting stuff in it) and saw this:

Upstreamed some important copy construction glitch fixes for Collection and PODCollection from my psxwadgen project, where I caused undefined behavior by trying to copy-construct them in the patch conversion code adopted from SLADE.

Just to be clear -- the undefined behavior came from SLADE's conversion code or purely on your code's side? I want to know if I have something to fix.

Share this post


Link to post
Gez said:

I was reading the changelog (found many amusing or interesting stuff in it) and saw this:

Just to be clear -- the undefined behavior came from SLADE's conversion code or purely on your code's side? I want to know if I have something to fix.

I replaced the uses there of vector<> with Eternity's PODCollection<> and Collection<> classes, which were not quite as robust as they needed to be. There's no issue in SLADE :)

Share this post


Link to post

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0